Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: fix incorrect style for IsolateInfo and RuleInfo of Network Policy panel #4180

Merged
merged 1 commit into from
Sep 21, 2023
Merged

style: fix incorrect style for IsolateInfo and RuleInfo of Network Policy panel #4180

merged 1 commit into from
Sep 21, 2023

Conversation

nekomeowww
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #4179

Before

image image image

After

image

Does this PR introduced a user-facing change?

Fixed the incorrect style for IsolateInfo and RuleInfo of Network Policy panel.

@ks-ci-bot ks-ci-bot added release-note kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 14, 2023
@ks-ci-bot
Copy link
Collaborator

Hi @nekomeowww. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harrisonliu5
Copy link
Contributor

/ok-to-test

@nekomeowww
style: fix incorrect style for IsolateInfo and RuleInfo of Network Po…
d254312 
…licy panel

Signed-off-by: Neko Ayaka <neko@ayaka.moe>
@nekomeowww
Copy link
Contributor Author

Any updates?

@harrisonliu5
Copy link
Contributor

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 502d5a3f47580e6db9cdc38daaf23b2e4d465784

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, nekomeowww

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2023
@ks-ci-bot ks-ci-bot merged commit 6122855 into kubesphere:master Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@harrisonliu5 harrisonliu5

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent style for panel in Network Isolation
3 participants
@nekomeowww @ks-ci-bot @harrisonliu5